-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native Windows build #13
Conversation
# Conflicts: # src/manifold/BVH.cpp # src/manifold/BVH.h # src/manifold/Manifold.cpp # src/manifold/Manifold.h # src/manifold/Octree.h # src/manifold/model.cpp # src/manifold/model.h
# Conflicts: # src/config.h # src/io.cpp # src/process.cpp
So the current version does not contain spdlog? What is the error of keeping that? |
@SarahWeiii for some obscure reason the logger update commit introduces uncomprehensible errors and compilation issues. not only is it complicated to make the spdlog dependency work nicely on windows and cmake and vcpkg but also past this there is just nothing helpful to fix the situation in terms of error. the This is the maximum I could do. if you are ok with this PR erasing the update logger code tell me and I'll fix the conflict of the PR. Compilation Log
|
Hi I have added an option in CMakeLists.txt for turning off spdlog, could you try if your code works on top of the current version? |
thanks, 👍 will try in a day or two |
Hi we have updated the code and support the Python version on Windows now. |
fix for issue : #9
Here's the PR @SarahWeiii
things to know about it :
before merging please make sure it works on your linux machine