Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise About dialog #91

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

spdkimo
Copy link
Collaborator

@spdkimo spdkimo commented Jun 14, 2023

Previously, Help > About dialog shows git version as default. In forked repositories, ioter is showing different version information. So the way to fetch version is updated that version is referred to config.json

Previously, Help > About dialog shows git version as default.
In forked repositories, ioter is showing different version information.
So the way to fetch version is updated that version is referred to config.json
Copy link
Collaborator

@junyong-sim junyong-sim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spdkimo spdkimo linked an issue Jun 14, 2023 that may be closed by this pull request
@spdkimo spdkimo merged commit 1b545de into Samsung:main Jun 14, 2023
@spdkimo spdkimo deleted the spdkimo-revise-version branch June 16, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default version is needed
2 participants