changed the operation method of autod #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ef122f
to
d3516ae
Compare
junyong-sim
reviewed
Apr 28, 2023
| if comport in self.parent.dialog: | ||
| if not self.parent.dialog[comport].get_window().pushButtonDevicePower.isChecked(): | ||
| self.parent.dialog[comport].get_window( | ||
| ).pushButtonDevicePower.toggle() | ||
| else: |
There was a problem hiding this comment.
if comport in self.parent.dialog:
if not self.parent.dialog[comport].get_window().pushButtonDevicePower.isChecked():
self.parent.dialog[comport].get_window(
).pushButtonDevicePower.toggle()
I think this routine is duplicate at many places. Can we make this routine as function ?
There was a problem hiding this comment.
That's a good idea
I will apply.
junyong-sim
reviewed
Apr 28, 2023
src/auto_onboarding/autod.py
Outdated
| self.step = 2 | ||
| continue | ||
| self.step = 0 | ||
| elif self.step == 2: |
There was a problem hiding this comment.
"2" means ONBOARDING_MANUAL_PAIRING_CODE_BOTTON ?
If yes, how about using constants to determine step, instead of number ?
There was a problem hiding this comment.
It's a different value.
I will define and use the value
junyong-sim
reviewed
Apr 28, 2023
so made it work with on thread
06aab5c
to
75f568b
Compare
sangsoolee
approved these changes
May 2, 2023
src/common/common_window.py
Outdated
| @@ -121,7 +130,7 @@ def power_onoff(self, state): | |||
| self.ioter.launch_chip_all_clusters(self.device_info) | |||
| self.textBrowserLog.append("=== Matter Commissioning ===") | |||
|
|
|||
| # self는 WindowClass의 인스턴스, Thread 클래스에서 parent로 전달 | |||
| # self??WindowClass???�스?�스, Thread ?�래?�에??parent�??�달 | |||
There was a problem hiding this comment.
pls check the comment and if possible, pls write not Kor but Eng
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autod was moved from each device to main
so made it work with on thread