[AutoOnboarding] Fix force close issue #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Problem] Disconnecting phone make close the device dialog despite of that onboarding has finished successfully [Cause] autoDevice.stop() always turns off last onboarded device [Measure] Add a condition that checks a onboarding status to autoDevice.stop()
junyong-sim
reviewed
Jul 3, 2023
1. The phone is disconnected during auto-onboarding process, maintain the current operation. 2. ADB connectivity is shown on status bar for 3000ms 3. The phone is disconnected during repeat-test process, maintain the current operation and display report dialog
dooho-lee
previously approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Problem] Disconnecting phone make close the device dialog despite of that onboarding has finished successfully
[Cause] autoDevice.stop() always turns off last onboarded device
[Measure] Add a condition that checks a onboarding status to autoDevice.stop()