Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ESM, change node requirement to node 14 #11

Merged
merged 19 commits into from
Dec 15, 2022
Merged

Switch to ESM, change node requirement to node 14 #11

merged 19 commits into from
Dec 15, 2022

Conversation

void-spark
Copy link
Contributor

No description provided.

@void-spark void-spark mentioned this pull request Dec 14, 2022
Closed
SamVerschueren
SamVerschueren requested changes Dec 14, 2022
View reviewed changes
Copy link
Owner

@SamVerschueren SamVerschueren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave some feedback. I think overall this is pretty good 👍 .

Can you also update the readme.md to use import decodeURIComponent from 'decode-uri-component'; instead of the require?

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
index.mjs Outdated Show resolved Hide resolved
index.mjs Outdated Show resolved Hide resolved
index.mjs Outdated Show resolved Hide resolved
index.mjs Outdated Show resolved Hide resolved
.github/workflows/main.yaml Outdated Show resolved Hide resolved
test.mjs Outdated Show resolved Hide resolved
test.mjs Outdated Show resolved Hide resolved
@void-spark
Copy link
Contributor Author

@SamVerschueren I think I addressed everything, and the tests still pass :)
See the unresolved conversations for info (the rest is done as suggested).

@SamVerschueren SamVerschueren merged commit b09e39d into SamVerschueren:main Dec 15, 2022
@SamVerschueren
Copy link
Owner

Awesome work @void-spark 🙏 !

@SamVerschueren
Copy link
Owner

Released as 0.4.0.

@void-spark void-spark mentioned this pull request Dec 16, 2022
Closed
@void-spark
Copy link
Contributor Author

Well, now @sindresorhus just needs to update the dependencies to the ECM versions:
"decode-uri-component": "^0.4.0",
"split-on-first": "^3.0.0"
Seems anyone who hasn't committed to query-string cannot open or comment on issues anymore, so hope he sees this :)

@SamVerschueren
Copy link
Owner

Just sent a PR to the query-string package with the updated versions.

Repository owner locked and limited conversation to collaborators Apr 2, 2023
Repository owner deleted a comment Apr 11, 2023
Repository owner deleted a comment from sandritis2 Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamVerschueren SamVerschueren SamVerschueren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@void-spark @SamVerschueren