Merge pull request JuliaLang#10400 from JuliaLang/jcb/pushchg

Force push! and unshift! to need at least one item
Sacha0 · Mar 5, 2015 · 27b6bbf · 27b6bbf
2 parents ded4bd4 + 8df4704
commit 27b6bbf
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -197,6 +197,8 @@ Library improvements
 Deprecated or removed
 ---------------------
 
+ * `push!(A)` has been deprecated, use `append!` instead of splatting arguments to `push!` ([#10400]).
+
  * `names` for composite datatypes has been deprecated and
  renamed to `fieldnames` ([#10332]).
 

diff --git a/base/abstractarray.jl b/base/abstractarray.jl
@@ -1453,10 +1453,8 @@ end
 
 # multi-item push!, unshift! (built on top of type-specific 1-item version)
 # (note: must not cause a dispatch loop when 1-item case is not defined)
-push!(A) = A
 push!(A, a, b) = push!(push!(A, a), b)
 push!(A, a, b, c...) = push!(push!(A, a, b), c...)
-unshift!(A) = A
 unshift!(A, a, b) = unshift!(unshift!(A, b), a)
 unshift!(A, a, b, c...) = unshift!(unshift!(A, c...), a, b)
 

diff --git a/base/deprecated.jl b/base/deprecated.jl
@@ -307,3 +307,8 @@ end
 
 @deprecate names(t::DataType) fieldnames(t)
 @deprecate names(v) fieldnames(v)
+
+function push!(A)
+ depwarn("push!(A) has been deprecated", :push!)
+ A
+end
diff --git a/doc/stdlib/collections.rst b/doc/stdlib/collections.rst
@@ -800,7 +800,7 @@ Dequeues
 
 .. function:: push!(collection, items...) -> collection
 
- Insert zero or more ``items`` at the end of ``collection``.
+ Insert one or more ``items`` at the end of ``collection``.
 
  .. doctest::
 
@@ -846,7 +846,7 @@ Dequeues
 
 .. function:: unshift!(collection, items...) -> collection
 
- Insert zero or more ``items`` at the beginning of ``collection``.
+ Insert one or more ``items`` at the beginning of ``collection``.
 
  .. doctest::