Remote arrays addition #644
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Oct 29, 2018
| auto const& code = phylanx::execution_tree::compile(codestr, snippets, env); | ||
| return code.run(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Couldn't the above functions be unified into one?
hkaiser
reviewed
Oct 29, 2018
hkaiser
reviewed
Oct 29, 2018
|
|
||
| auto et2 = compile(code2, there); | ||
| et2(a2, b2); | ||
| } |
There was a problem hiding this comment.
I think we're interested in the result as a whole (i.e. stacking the results together again).
hkaiser
reviewed
Oct 29, 2018
| ), | ||
| code2 | ||
| ))"; | ||
|
|
There was a problem hiding this comment.
code1 and code2 are identical. Do we need both?
|
@weilewei please have a look here for how your code could be simplified and streamlined: https://github.com/STEllAR-GROUP/phylanx/blob/function_call_attributes/tests/unit/distributed/remote_add.cpp |
|
@hkaiser looks great to me! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a case of element-wise arrays addition using two localities