Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back explicit template parameters to lock_guards for nvcc #5996

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

msimberg
Copy link
Contributor

Fixes compilation with nvcc. I can also make the template arguments conditional on whether CUDA was enabled or not if you prefer.

@msimberg msimberg added type: defect compiler: nvcc category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals labels Aug 30, 2022
@hkaiser hkaiser added this to the 1.9.0 milestone Aug 30, 2022
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Aug 31, 2022

bors merge

@bors
Copy link

bors bot commented Aug 31, 2022

Build succeeded:

@bors bors bot merged commit a4544fb into STEllAR-GROUP:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals compiler: nvcc type: defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants