Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tileset tile size instead of map tile size for reporting tile size #109

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

tmpsantos
Copy link
Contributor

This is an issue when the tile size doesn't perfectly match the map grid size which is a supported use case.

Fixes #108

This is an issue when the tile size doesn't perfectly match the map
grid size which is a supported use case.
@tmpsantos
Copy link
Contributor Author

I will probably need to rebase this if #107 gets accepted.

@SSBMTonberry
Copy link
Owner

SSBMTonberry commented Nov 5, 2023

@tmpsantos : Your change seems to make sense, so I'll just accept this 😜
Thank you very much for your contribution! 🙏

@SSBMTonberry SSBMTonberry merged commit 5e37e68 into SSBMTonberry:master Nov 5, 2023
14 checks passed
@tmpsantos tmpsantos deleted the tmpsantos-tile_rect branch November 5, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tile::getDrawingRect() size is the map grid size, not the tile grid size
2 participants