Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with gcc-11/g++-11 on MacOSX 12.3 Monterey #36

Open
fgygi opened this issue Apr 8, 2022 · 1 comment
Open

Build fails with gcc-11/g++-11 on MacOSX 12.3 Monterey #36

fgygi opened this issue Apr 8, 2022 · 1 comment

Comments

@fgygi
Copy link

fgygi commented Apr 8, 2022

Building SSAGES-0.9.3-alpha for Qbox fails using gcc-11/g++-11 on MacOSX 12.3 Monterey. The build is using openmpi-4.1.2.
The cmake command is cmake -DQBOX=yes .. -DCMAKE_C_COMPILER=gcc-11 -DCMAKE_CXX_COMPILER=g++-11 .
The make command fails due to a missing #include <cstdio> in SAGES-0.9.3-alpha/include/mxx/common.hpp.

/Users/fgygi/software/ssages/SSAGES-0.9.3-alpha/include/mxx/common.hpp:41:5: error: 'printf' was not declared in this scope
   41 |     printf("\n[Rank %d] %s:%d: %s: Assertion `%s` failed. Aborting.\n", rank, file, line, func, cond);
      |     ^~~~~~
/Users/fgygi/software/ssages/SSAGES-0.9.3-alpha/include/mxx/common.hpp:1:1: note: 'printf' is defined in header '<cstdio>'; did you forget to '#include <cstdio'?
  +++ |+#include <cstdio>
    1 | /*

Adding that #include statement fixes the issue and the build completes.

pabloferz added a commit to pabloferz/mxx that referenced this issue Apr 13, 2022
When compiling a library that depends on this on MacOS Monterry with gcc and OpenMPI (both installed via homebrew) the build fails because of `cstdio` missing (see [here](SSAGESproject/SSAGES#36)).

Everything works well when building with clang instead. But I saw no harm in explicitly including `cstdio`.
@pabloferz
Copy link
Contributor

Fixed upstream. We always grab the master branch of mxx so this should work now. Can you confirm this @fgygi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants