Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pytproject.toml file #19

Merged
merged 7 commits into from
May 19, 2021
Merged

Add a pytproject.toml file #19

merged 7 commits into from
May 19, 2021

Conversation

InnocentBug
Copy link
Member

This hopefully defines a good build environment for plum-dispatch.

@InnocentBug
Copy link
Member Author

Ok, so I researched it a bit.
setuptools does not fully support integration with pyproject.toml. See here for their discussion on it. pypa/setuptools#1688

However, what they propose is to eliminate setup.py entirely. Which solves our issue, because if you remove the setup.py users are forced to install via pip directly.

We could specify all the config of setup.py in setup.cfg and make the build environment in pyproject.toml. The only thing that wouldn't work in the current scenario is the automatic version determination via minivers.
So if move back to manual specification of the version, I can try it out.

I am not really a fan of this, but maybe it is lesser evil.

@pabloferz
Copy link
Member

pabloferz commented May 19, 2021

It seems that there are efforts to deprecate installing via setup.py anyway. In case we do that and leave only a pyproject.toml and setup.cfg, we should be able to use https://github.com/pypa/setuptools_scm/ as alternative to miniver, as it looks to be compatible with pyproject.toml (and seems to be the closest to an official way of doing this)

@InnocentBug
Copy link
Member Author

Good idea to switch to the setuptools_scm.

I implemented it and could drop the setup.py entirely.
A bit ironic, because this is what I originally wanted, but pyproject.toml seems to be the future.

@InnocentBug InnocentBug marked this pull request as ready for review May 19, 2021 20:36
@pabloferz pabloferz merged commit cee097b into SSAGESLabs:main May 19, 2021
@InnocentBug InnocentBug deleted the toml branch October 5, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants