Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource leak in ReplaySubject #802

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Fix resource leak in ReplaySubject #802

merged 2 commits into from
Mar 13, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented Mar 13, 2024

Description

This PR allows us to fix an issue related to resources that were not released.

Changes made

  • Removes cancelled subscription from subscription collection.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@waliid waliid linked an issue Mar 13, 2024 that may be closed by this pull request
Resource leak in ReplaySubject #801
Closed
1 task
@defagos defagos added this pull request to the merge queue Mar 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2024
@waliid waliid added this pull request to the merge queue Mar 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2024
@defagos defagos added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit edfcb80 Mar 13, 2024
6 checks passed
@defagos defagos deleted the 801-resource-leak-in-replaysubject branch March 13, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource leak in ReplaySubject
2 participants
@waliid @defagos