Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Control Center metadata sometimes disappearing after item deletion #786

Conversation

defagos
Copy link
Member

@defagos defagos commented Mar 10, 2024

Description

This PR fixes an issue with Control Center metadata sometimes disappearing after item deletion, e.g. after reshuffling the item after the current one with another down in a playlist, then deleting the current item.

The issue was located in our ReplaySubject implementation (similar implementations like CombineExt or Entwine have the same issue). See #785 for an explanation of the issue and how to solve it.

Changes made

  • Fix ReplaySubject implementation to support in-order value processing in multicast configurations where some subscriber might trigger a new publisher emission on the same thread.
  • Make ReplaySubject public (just an oversight).
  • Extracted QueuePlayer-related types into separate files (general improvement).

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos linked an issue Mar 10, 2024 that may be closed by this pull request
1 task
@defagos defagos enabled auto-merge March 10, 2024 07:28
@defagos defagos added this pull request to the merge queue Mar 10, 2024
Merged via the queue into main with commit e639403 Mar 10, 2024
6 checks passed
@defagos defagos deleted the 785-control-center-metadata-may-disappear-on-current-item-deletion branch March 10, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control Center metadata may disappear on current item deletion
2 participants