Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for complete localization #782

Merged
merged 7 commits into from
Mar 4, 2024
Merged

Prepare for complete localization #782

merged 7 commits into from
Mar 4, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Mar 1, 2024

Description

This PR prepares the PillarboxPlayer and PillarboxCoreBusiness libraries for localization. Remaining translations still must be requested and integrated in a future PR.

Changes made

  • Fix playback errors not being correctly detected anymore after Support standard actions at item playback end #780.
  • Revisit error management to ensure that all error messages are properly localized. The debug description is checked before having a look at an item error log, since errors associated with items are often better localized (errors in the errro log are still useful and localized, though, especially custom errors thrown by resource loaders).
  • Remove several keys for which translation is not needed.
  • Prepare files, translations and screenshots on Crowdin.

Only a single key is set to manual mode in the string catalog (string which belongs to the iOS code only and which would otherwise be removed when compiling for tvOS).

Note that the code has been tested on iOS 17 and 16 (simulator only). The new error management works fine.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos linked an issue Mar 1, 2024 that may be closed by this pull request
6 tasks
@defagos defagos enabled auto-merge March 1, 2024 13:50
Sources/Player/Types/ItemError.swift Show resolved Hide resolved
Sources/Player/Types/ItemError.swift Outdated Show resolved Hide resolved
@defagos defagos added this pull request to the merge queue Mar 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2024
@waliid waliid added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 1579544 Mar 4, 2024
6 checks passed
@waliid waliid deleted the 776-localization branch March 4, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization
2 participants