[WIP] [Stock Market] Add New Cog #554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrates the Real life stock market into Ren! Thought adding new ways to gain/lose credits might be fun. Also, has the added benefit of teaching people how to invest and gaining experience losing money. Unlike Squid.py, effort was put in. Oh, and comments... yea kinda forgot about those midway so, you got this! Its fairly simple code so should be alright without it. Couple of issues are still present in no particular order: - Its slow, that needs to be worked on, especially for the buy and sell functions - The output could be prettier. - Buy & Sell functions are kinda messy. Needs to be cleaned up. - For the charts, the time stamps are weird if you view a stock when its currently being traded on the market WIP/To-Do: - Dividends (think of it as adult allowance for the financial illiterate) - buy/sell with the full company name instead of tickers
Injabie3
requested changes
May 8, 2022
Injabie3
requested changes
May 22, 2022
Added Type hints
Revert "Added Type hints"
[AfterHours] Added Type Hints
New File(s): - Created utils.py that contains abstracted functions for market.py Changes to constants.py - Constants class removed and all single quotes changed to double quotes - Added a constant for the maximum message length and the price multiplier - Removed some quips and adjusted punctuation Changes to market.py: - Cognitive complexity is lower - most functions are now abstracted away and moved into utils.py
Injabie3
requested changes
Aug 7, 2022
cogs/stockmarket/constants.py
Outdated
Comment on lines
6
to
7
| DATA_FILE = "cogs\\stockmarket\\portfolios.json" | ||
| EMBED_LOCATION = "cogs\\stockmarket\\chart.jpg" |
There was a problem hiding this comment.
Can you please make these paths platform-agnostic? This would work on Windows but not Linux.
cogs/stockmarket/constants.py
Outdated
| INVALID_TICKER_STR = "Invalid ticker symbol!" | ||
| INVALID_AMOUNT_STR = "Invalid amount!" | ||
| POOR_STR = "You do not have enough money to buy this stock!" | ||
| ACCOUNT_NOT_FOUND_STR = """No account found! Please create an account using `renmarket createacc`.""" # .format(get prefix somehow) |
| import time | ||
| import datetime | ||
| import matplotlib.pyplot as plt | ||
| import yfinance as yf # pip install yfinance |
There was a problem hiding this comment.
Please include a info.json and put this as a requirements. You can see other cogs (i.e. YOURLS) for examples.
cogs/stockmarket/market.py
Outdated
Comment on lines
87
to
92
| @market.command(name="debug") | ||
| async def market_debug(self, ctx: commands.Context): | ||
| """Debugging command""" | ||
| # print out all the data | ||
| all_member_data = await self.config.all_members(guild=None) | ||
| print(all_member_data) |
There was a problem hiding this comment.
This should be protected by some mod/admin equivalent check.
cogs/stockmarket/market.py
Outdated
Comment on lines
157
to
158
| embed_file = discord.File(EMBED_LOCATION, filename=ticker + ".jpg") | ||
| embed.set_image(url="attachment:https://image.jpg") |
There was a problem hiding this comment.
Does this work if the filename doesn't match the one you're setting with set_image?
cogs/stockmarket/market.py
Outdated
Comment on lines
15
to
16
| from .constants import * | ||
| from .utils import * |
There was a problem hiding this comment.
Probably some other places are using import *, but can we please explicitly import all attributes that you need? Makes tracing where names are coming from easier.
cogs/stockmarket/market.py
Outdated
| self, | ||
| ctx: commands.Context, | ||
| ticker: str, | ||
| amount_to_sell: int = 0, |
There was a problem hiding this comment.
Any reason not to include default of 0 and let the infra print out the help string if the amount to sell isn't provided?
cogs/stockmarket/market.py
Outdated
Comment on lines
100
to
106
| user_id: discord.Member = None, | ||
| ): | ||
| """Sell a user-specified amount of a stock""" | ||
| ticker = ticker.upper() | ||
|
|
||
| if user_id is None: | ||
| user_id = ctx.author |
There was a problem hiding this comment.
Re:user_id, can we rename this to something that doesn't include ID, since this is not a user ID but rather the Member object itself.
cogs/stockmarket/market.py
Outdated
Comment on lines
216
to
217
| if user_id is None: | ||
| user_id = ctx.author |
cogs/stockmarket/utils.py
Outdated
Comment on lines
70
to
72
| # so messy... | ||
| async def build_embed(self, ctx: commands.Context, price: int, ticker: str, ticker_info: dict): | ||
| """Builds the embed""" |
There was a problem hiding this comment.
nit: does this need to be inside the class? I don't see self being used anywhere in this helper.
Messed up my local git repo so it doesn't contain the 30 or so changes. Still kinda figuring this stuff out.
Injabie3
reviewed
Sep 10, 2022
…s-at-root Removing accidentally placed files at root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Also balanced all the casino games so that the expected value is roughly all the same.