libsemanage: fix src/genhomedircon.c build on gcc-14 (`-Werror=allo…

[trofi]

…c-size`)

gcc-14 added a new -Walloc-size warning that makes sure that size of an individual element matches size of a pointed type:

https://gcc.gnu.org/PR71219

libsemanage triggers it on calloc() calls where member size is used as 1 (instead of member count):

genhomedircon.c: In function 'ignore_setup':
genhomedircon.c:152:21:
  error: allocation of insufficient size '1' for type 'ignoredir_t'
    {aka 'struct IgnoreDir'} with size '16' [-Werror=alloc-size]
  152 |                 ptr = calloc(sizeof(ignoredir_t),1);
      |                     ^

[jwcart2]

Thank you for the patch!

For your patch to be reviewed and accepted it must be sent to the [email protected] mailing list. You can use git send-email to do that.

It looks like there are multiple places throughout the SELinux userspace where the number of elements and size of an element are swapped in a calloc call.

Thanks again,
Jim

[trofi]

Sent the patch as https://lore.kernel.org/selinux/[email protected]/T/#u . Will send more if I get to other components.

Thank you Jim!