ebitmap optimizations #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgzones
force-pushed
the
ebitmap_opt
branch
3 times, most recently
from
ff2dea4
to
8eeed1e
Compare
Preparation for several ebitmap related optimizations. Signed-off-by: Christian Göttsche <[email protected]> --- v2: - add more tests for multi node ebitmaps and for bits set at node bounds - test ebitmap_for_each_bit()
Add an initializer for ebitmaps that sets all bits in a given range to save node traversals for each bit to set, compared to calling ebitmap_init() followed by iterating ebitmap_set_bit(). Signed-off-by: Christian Göttsche <[email protected]> --- v2: use braces for all if-else branches when used for at least one of them
Especially in the case of __cil_permissionx_expr_range_to_bitmap_helper() it substitutes hundreds of thousand of calls to ebitmap_set_bit() during semodule(8) on a policy widely using extended permissions. Signed-off-by: Christian Göttsche <[email protected]>
Iterate on nodes instead of single bits to save node resolution for each single bit. Signed-off-by: Christian Göttsche <[email protected]>
Iterate on nodes instead of single bits to save node resolution for each single bit. Signed-off-by: Christian Göttsche <[email protected]> --- v2: use braces for all if-else branches when used for at least one of them
Iterate on nodes instead of single bits to save node resolution for each single bit. Signed-off-by: Christian Göttsche <[email protected]>
The three members of struct ebitmap_node are all unconditionally initialized. Hinder compilers to optimize malloc() and memset() into calloc(), which might be slightly slower. Especially affects ebitmap_or(). Signed-off-by: Christian Göttsche <[email protected]>
|
The commits in the PR have been merged: https://github.com/SELinuxProject/selinux/commits/fc7bb9f05a3e8658b3745cc65a8b8e624498e56c . Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.