Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate libselinux functions #357

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Annotate libselinux functions #357

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9f30d63
libselinux: annotate interfaces with compiler attributes
cgzones Jun 16, 2022
154a956
libselinux: deprecate matchpathcon and compute_user interfaces
cgzones Jun 16, 2022
aad6324
libselinux: declare avc_open(3) options parameter const
cgzones Jun 16, 2022
a0b882f
mcstrans: check getcon(3) and context_range_set(3) for failure
cgzones Jun 16, 2022
1e59a42
libselinux: explicitly ignore return values
cgzones Jun 16, 2022
80a5c86
libselinux: ignore internal use of deprecated interfaces
cgzones Jun 16, 2022
9ff1915
secon: check selinux_raw_to_trans_context(3) for failure
cgzones Jun 16, 2022
3e05a92
restorecond: check selinux_restorecon(3) for failure
cgzones Jun 16, 2022
87daeb4
restorecond: drop last matchpathcon call
cgzones Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
secon: check selinux_raw_to_trans_context(3) for failure 
    secon.c: In function ‘disp_con’:
    secon.c:634:9: error: ignoring return value of ‘selinux_raw_to_trans_context’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
      634 |         selinux_raw_to_trans_context(scon_raw, &scon_trans);
          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Christian Göttsche <[email protected]>
  • Loading branch information
@cgzones
cgzones committed May 12, 2023
commit 9ff1915e457984f7c9ab8dd99da0e768a156bfde
7 changes: 5 additions & 2 deletions policycoreutils/secon/secon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#include <stdlib.h>
#include <stdio.h>
#include <assert.h>

#include <errno.h>
#include <string.h>

#define xstreq(x, y) !strcmp(x, y)
Expand Down Expand Up @@ -631,7 +631,10 @@ static void disp_con(const char *scon_raw)
char *color_str = NULL;
struct context_color_t color = { .valid = 0 };

selinux_raw_to_trans_context(scon_raw, &scon_trans);
if (selinux_raw_to_trans_context(scon_raw, &scon_trans) < 0)
errx(EXIT_FAILURE, "Couldn't convert context %s: %s",
scon_raw, strerror(errno));

if (opts->disp_raw)
scon = scon_raw;
else
Expand Down