secilc: add check for malloc in secilc

Check the return value of malloc() to avoid null pointer reference. Signed-off-by: Huaxin Lu <[email protected]> Acked-by: James Carter <[email protected]>
SELinuxProject · Aug 4, 2023 · 04613f6 · 04613f6
1 parent 8730e07
commit 04613f6
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/secilc/secil2conf.c b/secilc/secil2conf.c
@@ -152,6 +152,12 @@ int main(int argc, char *argv[])
  file_size = filedata.st_size;
 
  buffer = malloc(file_size);
+ if (!buffer) {
+ fprintf(stderr, "Out of memory\n");
+ rc = SEPOL_ERR;
+ goto exit;
+ }
+
  rc = fread(buffer, file_size, 1, file);
  if (rc != 1) {
  fprintf(stderr, "Failure reading file: %s\n", argv[i]);

diff --git a/secilc/secil2tree.c b/secilc/secil2tree.c
@@ -158,6 +158,12 @@ int main(int argc, char *argv[])
  file_size = filedata.st_size;
 
  buffer = malloc(file_size);
+ if (!buffer) {
+ fprintf(stderr, "Out of memory\n");
+ rc = SEPOL_ERR;
+ goto exit;
+ }
+
  rc = fread(buffer, file_size, 1, file);
  if (rc != 1) {
  fprintf(stderr, "Failure reading file: %s\n", argv[i]);

diff --git a/secilc/secilc.c b/secilc/secilc.c
@@ -286,6 +286,12 @@ int main(int argc, char *argv[])
  }
 
  buffer = malloc(file_size);
+ if (!buffer) {
+ fprintf(stderr, "Out of memory\n");
+ rc = SEPOL_ERR;
+ goto exit;
+ }
+
  rc = fread(buffer, file_size, 1, file);
  if (rc != 1) {
  fprintf(stderr, "Failure reading file: %s\n", argv[i]);