Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates #12

Merged
merged 8 commits into from
Apr 24, 2024
Merged

Updates #12

merged 8 commits into from
Apr 24, 2024

Conversation

rommansabbir
Copy link
Contributor

Change Logs:

  • Player background marked as clickable to stop taking action from user when view is overlaying.
  • Added support for directly play track from the play list in chart detail view.
  • Added Top and Bottom padding for Chart Detail View and Updated Player View padding.

Screenshot_20240330_194611
Screenshot_20240330_194558
Screenshot_20240330_194547

SEAbdulbasit
SEAbdulbasit requested changes Mar 31, 2024
View reviewed changes
Copy link
Owner

@SEAbdulbasit SEAbdulbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, just 1 file needs to be removed.

shared/src/commonMain/kotlin/com/example/musicapp_kmp/decompose/ChartDetailsComponent.kt Show resolved Hide resolved
@SEAbdulbasit SEAbdulbasit merged commit 81bfd2b into SEAbdulbasit:master Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SEAbdulbasit SEAbdulbasit SEAbdulbasit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rommansabbir @SEAbdulbasit