Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default configuration file not used since commit f7373b7 #548

Closed
jeff-snyder opened this issue Mar 3, 2023 · 4 comments
Closed

Default configuration file not used since commit f7373b7 #548

jeff-snyder opened this issue Mar 3, 2023 · 4 comments
Assignees
@Fish-Git
Labels
BUG The issue describes likely incorrect product functionality that likely needs corrected.

Comments

@jeff-snyder
Copy link

jeff-snyder commented Mar 3, 2023 •
edited by Fish-Git
Loading

The changes made in commit f7373b7 have caused Hercules to stop defaulting to a configuration file name of "hercules.cnf". In the prior commit, hercules.cnf was read if it existed and a "file not found" error was raised if not. Since f7373b7, command usage errors are raised whether or not the configuration file exists.

As of commit: f7373b7

Start with a known environment

C:\Users\Jeff\Hercules\Software\f7373b7\hyperion\msvc.AMD64.bin>del hercules.cnf
Could Not Find C:\Users\Jeff\Hercules\Software\f7373b7\hyperion\msvc.AMD64.bin\hercules.cnf

Start Hercules, defaulting all options, including the filename

C:\Users\Jeff\Hercules\Software\f7373b7\hyperion\msvc.AMD64.bin>hercules
HHC01413I Hercules version 4.6.0.10881-SDL-DEV-gf7373b7c
HHC01414I (C) Copyright 1999-2023 by Roger Bowler, Jan Jaeger, and others
HHC01417I *** Hercules-Helper Test Build ***
HHC01415I Build date: Mar  2 2023 at 16:42:44
HHC01407S Usage: hercules [--help[=SHORT|LONG|VERSION|BUILD]] -f config-filename|"none" [-o logfile-name] [-r rcfile-name] [-d] [-b logo-filename] [-s sym=val] [-t [factor]] [-p dyn-load-dir] [[-l dynmod-to-load]...] [> logfile]
HHC00007I Previous message from function 'arghelp' at impl.c(787)
HHC02343S Terminating due to 1 argument errors
HHC00007I Previous message from function 'impl' at impl.c(842)

Create a configuration file

C:\Users\Jeff\Hercules\Software\f7373b7\hyperion\msvc.AMD64.bin>echo > hercules.cnf

Start Hercules again, showing it responds the same when the file exists

C:\Users\Jeff\Hercules\Software\f7373b7\hyperion\msvc.AMD64.bin>hercules
HHC01413I Hercules version 4.6.0.10881-SDL-DEV-gf7373b7c
HHC01414I (C) Copyright 1999-2023 by Roger Bowler, Jan Jaeger, and others
HHC01417I *** Hercules-Helper Test Build ***
HHC01415I Build date: Mar  2 2023 at 16:42:44
HHC01407S Usage: hercules [--help[=SHORT|LONG|VERSION|BUILD]] -f config-filename|"none" [-o logfile-name] [-r rcfile-name] [-d] [-b logo-filename] [-s sym=val] [-t [factor]] [-p dyn-load-dir] [[-l dynmod-to-load]...] [> logfile]
HHC00007I Previous message from function 'arghelp' at impl.c(787)
HHC02343S Terminating due to 1 argument errors
HHC00007I Previous message from function 'impl' at impl.c(842)

The prior commit: 468b76c

Start with a known environment

C:\Users\Jeff\Hercules\Software\468b76c\hyperion\msvc.AMD64.bin>del hercules.cnf
Could Not Find C:\Users\Jeff\Hercules\Software\468b76c\hyperion\msvc.AMD64.bin\hercules.cnf

Start Hercules, using all defaults. See the file not found (HHC02342S) message

C:\Users\Jeff\Hercules\Software\468b76c\hyperion\msvc.AMD64.bin>hercules
HHC00100I Thread id 000032a0, prio 5, name 'impl_thread' started
HHC00100I Thread id 00010170, prio 4, name 'logger_thread' started
HHC02342S Configuration file 'hercules.cnf' not found: No such file or directory
HHC00007I Previous message from function 'process_args' at impl.c(1900)
HHC02343S Terminating due to 1 argument errors
HHC00007I Previous message from function 'impl' at impl.c(1146)
HHC01420I Begin Hercules shutdown
HHC01423I Calling termination routines
HHC01424I All termination routines complete
HHC01425I Hercules shutdown complete
HHC01412I Hercules terminated

Create a configuration file

C:\Users\Jeff\Hercules\Software\468b76c\hyperion\msvc.AMD64.bin>echo > hercules.cnf

Start Hercules. It starts normally.

C:\Users\Jeff\Hercules\Software\468b76c\hyperion\msvc.AMD64.bin>hercules > hercules.log
< contents of hercules.log >
16:51:09 HHC00100I Thread id 0000c94c, prio 5, name 'impl_thread' started
16:51:09 HHC00100I Thread id 00011874, prio 4, name 'logger_thread' started
16:51:09 HHC01413I Hercules version 4.6.0.10880-SDL-DEV-g468b76cd
16:51:09 HHC01414I (C) Copyright 1999-2023 by Roger Bowler, Jan Jaeger, and others
16:51:09 HHC01417I *** Hercules-Helper Test Build ***
16:51:09 HHC01415I Build date: Mar  2 2023 at 16:36:27
16:51:09 HHC01417I Built with: Microsoft Visual Studio 2019 (MSVC 192930139 0)
16:51:09 HHC01417I Build type: Windows MSVC AMD64 host architecture build
16:51:09 HHC01417I Modes: S/370 ESA/390 z/Arch
16:51:09 HHC01417I Max CPU Engines: 8
16:51:09 HHC01417I Using   shared libraries
16:51:09 HHC01417I Using   Fish threads Threading Model
16:51:09 HHC01417I Using   Error-Checking Mutex Locking Model
16:51:09 HHC01417I With    Shared Devices support
16:51:09 HHC01417I With    Dynamic loading support
16:51:09 HHC01417I With    External GUI support
16:51:09 HHC01417I With    Partial TCP keepalive support
16:51:09 HHC01417I With    IPV6 support
16:51:09 HHC01417I With    HTTP Server support
16:51:09 HHC01417I With    sqrtl support
16:51:09 HHC01417I With    Signal handling
16:51:09 HHC01417I With    Watchdog monitoring
16:51:09 HHC01417I With    CCKD BZIP2 support
16:51:09 HHC01417I With    HET BZIP2 support
16:51:09 HHC01417I With    ZLIB support
16:51:09 HHC01417I With    Regular Expressions support
16:51:09 HHC01417I With    Object REXX support
16:51:09 HHC01417I Without Regina REXX support
16:51:09 HHC01417I With    Automatic Operator support
16:51:09 HHC01417I Without National Language Support
16:51:09 HHC01417I With    CCKD64 Support
16:51:09 HHC01417I With    Transactional-Execution Facility support
16:51:09 HHC01417I With    "Optimized" instructions
16:51:09 HHC01417I With    OPTION_USE_SKAIP_AS_LOCK
16:51:09 HHC01417I With    OPTION_SIE2BK_FLD_COPY
16:51:09 HHC01417I Machine dependent assists: cmpxchg1 cmpxchg4 cmpxchg8 cmpxchg16 hatomics=msvcIntrinsics
16:51:09 HHC01417I Running on: SERVER (Windows-6.2.9200 Intel(R) x64) LP=8, Cores=4, CPUs=1
16:51:09 HHC01417I Built with crypto external package version 1.0.0.52-ga5096e5
16:51:09 HHC01417I Built with decNumber external package version 3.68.0.102-g3aa2f45
16:51:09 HHC01417I Built with SoftFloat external package version 3.5.0.105-g4b0c326
16:51:09 HHC01417I Built with telnet external package version 1.0.0.62-ge0e2a91
16:51:09 HHC00018W Hercules is NOT running in elevated mode
16:51:09 HHC00007I Previous message from function 'impl' at impl.c(1186)
16:51:09 HHC02323W This build of Hercules has only partial TCP keepalive support
16:51:09 HHC00007I Previous message from function 'impl' at impl.c(1232)
16:51:09 HHC00150I Crypto module loaded (C) Copyright 2003-2016 by Bernard van der Helm
16:51:09 HHC00151I Activated facility: Message Security Assist
16:51:09 HHC00151I Activated facility: Message Security Assist Extension 1, 2, 3 and 4
16:51:09 HHC17528I REXX(OORexx) VERSION: REXX-ooRexx_4.2.0(MT)_64-bit 6.04 22 Feb 2014
16:51:09 HHC17529I REXX(OORexx) SOURCE:  WindowsNT
16:51:09 HHC17525I REXX(OORexx) Rexx has been started/enabled
16:51:09 HHC17500I REXX(OORexx) Mode            : Command
16:51:09 HHC17500I REXX(OORexx) MsgLevel        : Off
16:51:09 HHC17500I REXX(OORexx) MsgPrefix       : Off
16:51:09 HHC17500I REXX(OORexx) ErrPrefix       : Off
16:51:09 HHC17500I REXX(OORexx) Resolver        : On
16:51:09 HHC17500I REXX(OORexx) SysPath    (22) : On
16:51:09 HHC17500I REXX(OORexx) RexxPath   ( 0) :
16:51:09 HHC17500I REXX(OORexx) Extensions ( 8) : .REXX;.rexx;.REX;.rex;.CMD;.cmd;.RX;.rx
16:51:09 HHC00111I Thread CPU Time IS available (_POSIX_THREAD_CPUTIME=1)
16:51:09 HHC00100I Thread id 00011cd0, prio 2, name 'Processor CP00' started
16:51:09 HHC00811I Processor CP00: architecture mode z/Arch
16:51:09 HHC01441E Config file[1] hercules.cnf: error processing statement: ECHO is on.
16:51:09 HHC00007I Previous message from function 'process_config' at script.c(431)
16:51:09 HHC00100I Thread id 00011d28, prio 7, name 'timer_thread' started
16:51:09 HHC02385W CPUMODEL 0586 does not technically support TXF
16:51:09 HHC00007I Previous message from function 'txf_model_warning' at transact.c(2562)
16:51:09 HHC17736W TXF: TIMERINT 50 is too small; using default of 400 instead
16:51:09 HHC00007I Previous message from function 'txf_set_timerint' at transact.c(2587)
16:51:09 HHC00100I Thread id 00011170, prio 2, name 'rubato_thread' started
16:51:13 HHC01603I quit
16:51:13 HHC01420I Begin Hercules shutdown
16:51:13 HHC01423I Calling termination routines
16:51:13 HHC00101I Thread id 00011cd0, prio 2, name 'Processor CP00' ended
16:51:13 HHC01427I Main storage released
16:51:13 HHC01427I Expanded storage released
16:51:13 HHC01422I Configuration released
16:51:13 HHC00101I Thread id 00011170, prio 2, name 'rubato_thread' ended
16:51:13 HHC00101I Thread id 00011d28, prio 7, name 'timer_thread' ended
16:51:14 HHC00101I Thread id 0000c94c, prio 5, name 'panel_display' ended
@Fish-Git Fish-Git self-assigned this Mar 3, 2023
@Fish-Git Fish-Git added BUG The issue describes likely incorrect product functionality that likely needs corrected. IN PROGRESS... I'm working on it! (Or someone else is!) labels Mar 3, 2023
Fish-Git added a commit that referenced this issue Mar 3, 2023
@Fish-Git
Fix commit f7373b7:
440e62e 
Show version and help if no arguments given, but ONLY IF default config file isn't found. Otherwise use the default config file just as we always were prior to commit f7373b7.

Fixes GitHub Issue #548.
@Fish-Git
Copy link
Member

Fish-Git commented Mar 3, 2023

Sorry about that!

Should be fixed now by commit 440e62e.

Closing.

@Fish-Git Fish-Git closed this as completed Mar 3, 2023
@Fish-Git Fish-Git removed the IN PROGRESS... I'm working on it! (Or someone else is!) label Mar 3, 2023
@jeff-snyder
Copy link
Author

That got it, thanks!

@wrljet
Copy link
Member

wrljet commented Mar 3, 2023 •
edited by Fish-Git
Loading

Jeff, I understand now why you wanted that new feature in Hercules-Helper for Windows.   :)

Bill

@jeff-snyder
Copy link
Author

Yeah, that was really handy. I was able to write a Perl script to do it on Linux by massaging the config file, but I couldn't find a way with Windows. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fish-Git Fish-Git

Labels
BUG The issue describes likely incorrect product functionality that likely needs corrected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fish-Git @wrljet @jeff-snyder