Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the use of Perl in configure #454

Closed
Rhialto opened this issue Dec 19, 2021 · 3 comments
Closed

Avoid the use of Perl in configure #454

Rhialto opened this issue Dec 19, 2021 · 3 comments
Assignees
Labels
Enhancement This issue does not describe a problem but rather describes a suggested change or improvement. L Linux only issue, such as with tuntap networking that doesn't occur on Windows.

Comments

@Rhialto
Copy link
Contributor

Rhialto commented Dec 19, 2021

In configure.ac there are these lines:

dnl Kludge to fix Debian/Ubuntu libtool
perl -pi -e 's/link_all_deplibs=no/link_all_deplibs=yes/' libtool

As far as I can see, this is the only use of Perl in the actual building process. It would be nice to remove it, since it is a pretty expensive dependency.

The same effect can be had with (gnu)sed which is already a dependency. I haven't checked yet if any gnu specific features of gsed are used, and can be removed, but here I will avoid those:

sed -e 's/^link_all_deplibs=no$/link_all_deplibs=yes/' <libtool >libtool.new
mv libtool.new libtool

(adding the ^ and $ anchors while I'm there)

(There is some use of Perl in the git hooks, but those are only relevant when committing anything, so removing Perl for the build-only case is still worth it in my opinion)

@wrljet
Copy link
Member

wrljet commented Dec 19, 2021

I will test this on all my build test systems.
Bill

@Fish-Git Fish-Git added Enhancement This issue does not describe a problem but rather describes a suggested change or improvement. IN PROGRESS... I'm working on it! (Or someone else is!) L Linux only issue, such as with tuntap networking that doesn't occur on Windows. labels Dec 20, 2021
@wrljet
Copy link
Member

wrljet commented Jan 4, 2022

OK, I lied, I'm not going to test this on all my test systems, as there are just too many.
But I have tested this change on these:

  • Arch Linux (updated to latest)
  • Alma Linux 8.5
  • Debian 10
  • Fedora 34
  • FreeBSD 12.2
  • MacOS Big Sur 11.5
  • MacOS Monterey 12.1

I think this is a decent representative sample of the different major distributions.
All of the above are x86_64 versions, but I seriously doubt the sed is affected by the CPU type.

So... I'm going to go ahead and commit this change shortly to the develop branch.

Bill

wrljet added a commit that referenced this issue Jan 29, 2022
Switch from Perl to sed in configure, as suggested by Rhialto in
issue #454.
@wrljet
Copy link
Member

wrljet commented Jan 29, 2022

Changed in commit dabbf19

@wrljet wrljet closed this as completed Jan 29, 2022
@wrljet wrljet removed the IN PROGRESS... I'm working on it! (Or someone else is!) label Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This issue does not describe a problem but rather describes a suggested change or improvement. L Linux only issue, such as with tuntap networking that doesn't occur on Windows.
Projects
None yet
Development

No branches or pull requests

3 participants