Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPL command without a LOADPARM #296

Closed
arfineman opened this issue Apr 30, 2020 · 4 comments
Closed

IPL command without a LOADPARM #296

arfineman opened this issue Apr 30, 2020 · 4 comments
Labels
BUG The issue describes likely incorrect product functionality that likely needs corrected.

Comments

@arfineman
Copy link
Contributor

arfineman commented Apr 30, 2020 •
edited by Fish-Git
Loading

When IPL command without LOADPARM is issued, it uses the LOADPARM from the previous command. It should not. It should use the one from the config file, if one exist. None if there is none. LOADPARM from the IPL command should not be carried over from one command to another.
@SDL-Hercules-390 SDL-Hercules-390 deleted a comment from arfineman Apr 30, 2020
@Fish-Git Fish-Git added the BUG The issue describes likely incorrect product functionality that likely needs corrected. label Apr 30, 2020
@Fish-Git
Copy link
Member

Fish-Git commented Apr 30, 2020 •
edited
Loading

In other words, the loadparm option on the IPL command should be treated as only a temporary override of whatever the default loadparm is, with the default loadparm being: whatever was defined in the configuration file (i.e. via the loadparm command itself). Is that correct?

For example:

LOADPARM FOO        # from config file -OR- from "loadparm" panel command
IPL 0123
LOADPARM

should perform an IPL with the loadparm set to "FOO" and the "LOADPARM" command (without any arguments) should report that the default loadparm is currently set to "FOO", whereas:

LOADPARM FOO
IPL 0123 LOADPARM BAR
LOADPARM

should perform an IPL with the loadparm set to "BAR" and the "LOADPARM" command (without any arguments) should report that the default loadparm is STILL currently set to "FOO", and:

IPL 0123
LOADPARM

should perform an IPL with the loadparm set to blanks (i.e. nothing) and the "LOADPARM" command (without any arguments) should report that the default loadparm is currently blanks, and:

IPL 0123 LOADPARM BAR
LOADPARM

should perform an IPL with the loadparm set to "BAR" and the "LOADPARM" command (without any arguments) should report that the default loadparm is still currently set to blanks, and:

IPL 0123 LOADPARM BAR
LOADPARM
LOADPARM FOO
LOADPARM

should perform an IPL with the loadparm set to "BAR" and the first loadparm command (without any arguments) should report that the default loadparm is currently set to blanks, the second loadparm command should SET the default loadparm to "FOO", and the third loadparm command (without any arguments) should report that the default loadparm is NOW currently set to "FOO".

Is that correct?

If so, that seems perfectly reasonable to me!

Does anyone else have any objections to this change?

@arfineman
Copy link
Contributor Author

Yes. This is exactly how I believe it should work.

@Fish-Git Fish-Git added the IN PROGRESS... I'm working on it! (Or someone else is!) label May 1, 2020
@Fish-Git
Copy link
Member

Fish-Git commented May 1, 2020

Yes. This is exactly how I believe it should work.

Thought so.   :)

Fix in progress...

@Fish-Git
Copy link
Member

Fish-Git commented May 1, 2020

Fixed by commit 328e99a.

Closing issue.

@Fish-Git Fish-Git removed the IN PROGRESS... I'm working on it! (Or someone else is!) label May 1, 2020
Fish-Git added a commit that referenced this issue May 18, 2020
@Fish-Git
HUGE REVERT in preparation for "TXF" series of commits
efe1d01 
[skip travis]

Revert "3390 DASD CCW Command SNID (x'34') Correction for RESERVE/RELEASE"

This reverts commit 9fd1dff.

Revert "(Oops!) I did accidentally change functionality! Sorry!"

This reverts commit cb24398.

Revert "Clean up overall ARCH_DEP structure of hscmisc.c module:"

This reverts commit f99cae0.

Revert "Suppress HHC00814I and HHC00809I for OSTAILOR VM"

This reverts commit 97ef4d5.

Revert "Fix comments to match current state of controversy"

This reverts commit 7aa3c44.

Revert "Revert "Fix minor bug in CDFTR/CXFTR instructions""

This reverts commit e4e60f3.

Revert "Fix minor bug in CDFTR/CXFTR instructions"

This reverts commit 0f382a7.

Revert "Eliminate compiler warning."

This reverts commit a5ad6b0.

Revert "Add missing */ to facility 20 comment."

This reverts commit adfd31d.

Revert "Update What's New [skip travis]"

This reverts commit 5b5cdf0.

Revert "Fix z/VM guest arch switch bug identified in issue #295"

This reverts commit f5504fe.

Revert "Update documentation. [skip travis]"

This reverts commit 8caa8b1.

Revert "Fix for IPL command without a LOADPARM (#296)"

This reverts commit 328e99a.

Revert "(fix typo) [skip travis]"

This reverts commit 6665c10.

Revert "Update What's New and Release Notes web pages"

This reverts commit 21380cd.

Revert "Cosmetic: remove change indicator comments"

This reverts commit 3ff73f5.

Revert "Cosmetic: DIAG = RS_a format."

This reverts commit 67bc1d4.

Revert "Stop panel select watching logger pipe:"

This reverts commit bef8eb0.

Revert "(missed one!) [skip travis]"

This reverts commit 017e437.

Revert "Minor cosmetic inst format fixes"

This reverts commit c97e01a.

Revert "Instruction decoders cleanup part 8: IBM formats:"

This reverts commit 977de05.

Revert "CTCE v2 Circumventing VM/SP Problem and Minor Improvements"

This reverts commit 5080ee8.

Revert "Fix incomplete network device group crash:"

This reverts commit 590623a.

Revert "Workaround for VS2019 compiler bug:"

This reverts commit 3a94e28.

Revert "Documentation: clarify QETH statement "iface" parameter."

This reverts commit 216da21.

Revert "Disable DEBUG_FREESPACE build option:"

This reverts commit 68d91c0.

Revert "Minor cosmetic + cosmetic typo fix"

This reverts commit e1cbea7.

Revert "I/O interrupt tracing tweak:"

This reverts commit e004d29.

Revert "Cosmetic in preparation for next commit"

This reverts commit 456a0c4.

Revert "100% cosmetic: [skip travis]"

This reverts commit 5da6a86.

Revert "Cosmetic doc update to HERCLOGO readme [skip travis]"

This reverts commit 7efbcef.

Revert "Add dummy device to MSVC Windows build"

This reverts commit 9182101.

Revert "Cosmetic: reorg into alpha seq [skip travis]"

This reverts commit 382185e.

Revert "Chore: finalize dummy device skeleton"

This reverts commit 73a69e3.

Revert "Fix : Updates to dummy device skeleton"

This reverts commit 9f4c91c.

Revert "(cosmetic) [skip travis]"

This reverts commit 125c455.

Revert "Instruction decoders cleanup part 7: delete unused IPRINT_FUNC"

This reverts commit fb6f3d5.

Revert "Instruction decoders cleanup part 7: delete unused decoders"

This reverts commit 9e8b0e1.

Revert "Instruction decoders cleanup part 6: cosmetic:"

This reverts commit df8fd6e.

Revert "Fix: type in Makefile.am"

This reverts commit 73b3d56.

Revert "Updare Variuous anciliary files"

This reverts commit 49c3065.

Revert "Chore : tcpnje rewrite"

This reverts commit 011c66c.

Revert "Add missing Vector Facility macros"

This reverts commit 515c428.

Revert "Instruction decoders cleanup part 5: cosmetic:"

This reverts commit 9449825.

Revert "Instruction decoders cleanup part 4: fix RRD snafu:"

This reverts commit e899a61.

Revert "Instruction decoders cleanup parts 2 and 3:"

This reverts commit aa24c44.

Revert "Bug in SSF instruction decoder. Closes #287."

This reverts commit 2b6b899.

Revert "100% cosmetic (comment tweaks only)"

This reverts commit c78a12e.

Revert "Fix careless typo in RXXx_BC_DECODER (Sorry!)"

This reverts commit 8094e65.

Revert "(Oops!) decoders must be re-#included each time!"

This reverts commit 7089de5.

Revert "Instruction decoders cleanup part 1:"

This reverts commit c3e431b.

Revert "Fix TCP/NJE clang warnings + Windows support"

This reverts commit a73daad.

Revert "Add TCP/NJE readme file"

This reverts commit fc1c87c.

Revert "Chore: Add TCP/NJE support - Experimental"

This reverts commit a3355db.

Revert "Document yet more Hercules related support groups"

This reverts commit bdf46c2.

Revert "(yet more html doc tweaking)"

This reverts commit 7c29139.

Revert "Replace Yahoo URLs with Groups.IO URLs instead."

This reverts commit e0fb59a.

Revert "Replace Yahoo URLs with Groups.IO URLs instead."

This reverts commit b75b31e.

Revert "Copyright 2020: only what's visible to the user"

This reverts commit c2d6f83.

Revert "CTCE v2 Corrections and Improvements - Documentation Update"

This reverts commit 020e4a1.

Revert "(update 4.3 progress)"

This reverts commit 1a1d40d.

Revert "Fix sockdev "bind lock" initialization bug:"

This reverts commit 99504d3.

Revert "Use set_lock_name to assign better device lock names"

This reverts commit 8018f77.

Revert "Tighter lock init/destroy validation"

This reverts commit 63797f6.

Revert "Track lock creation"

This reverts commit 39782c0.

Revert "Cosmetic removal of superfluous location argument"

This reverts commit 0cead3d.

Revert "Yet more cosmetic renames"

This reverts commit fbd4aee.

Revert "Cosmetic struct field renames"

This reverts commit aba3237.

Revert "Fix minor memory leak in destroy_lock"

This reverts commit 7fc2064.

Revert "Fix some minor compiler warnings:"

This reverts commit 9f70f79.

Revert "CTCE v2 Corrections and Improvements - Documentation Update"

This reverts commit a575524.

Revert "CTCE Corrections and Improvements"

This reverts commit d2921aa.

Revert "CTCE devices need dev->hnd->halt to always be called"

This reverts commit 8ac28ed.

Revert "Support for new DEVLIST and CTC DEBUG command options"

This reverts commit 5ce233e.

Revert "(yet another typo)"

This reverts commit 66b91d2.

Revert "(typo!)"

This reverts commit 4c4b9c0.

Revert "Define framework for new facilities."

This reverts commit ad640b1.

Revert "New README to explain how to add a new Facility to Hercules"

This reverts commit 9bc2ade.

Revert "Still trying to fix travis-ci build failures!"

This reverts commit e36d1a8.

Revert "(cosmetic cleanup):"

This reverts commit 95b91e8.

Revert "Update *nix autoconf files due to last few commits"

This reverts commit 28d4f4b.

Revert "Various NetBSD/FreeBSD portability issues (#279):"

This reverts commit 56206ef.

Revert "Support perl being in a different place:"

This reverts commit 2f51035.

Revert "Update documentation regarding ongoing development"

This reverts commit 57d0e0d.

Revert "Fix minor message number typo"

This reverts commit 2e09371.

Revert "Minor bootstrap crash handler tweak:"

This reverts commit bec283f.

Revert "Restore watchdog support:"

This reverts commit 81957dd.

Revert "hthreads set/get thread name and lock name support"

This reverts commit f56bfb8.

Revert "New '$test deadlock' testing command"

This reverts commit 6690b92.

Revert "Restore DIAG FF8 and FFC for testing purposes"

This reverts commit 002e060.

Revert "Set sysblk.ipled flag on restart command too"

This reverts commit 866bda1.

Revert "(minor html edit)"

This reverts commit caaa3dc.

Revert "Update *nix autoconf files due to last few commits"

This reverts commit 23c7f6c.

Revert "Treat NetBSD same as FreeBSD per github issue #279"

This reverts commit 2ff0c0d.

Revert "Fix another portability issues identified in github issue #279"

This reverts commit 51a2450.

Revert "Support for NetBSD 3 arguments pthread_setname_np"

This reverts commit edf7171.

Revert "Fix some portability issues identified in github issue #279"

This reverts commit c740f71.

Revert "Restore erroneously removed printer immediate CCW opcodes tables:"

This reverts commit 9f2c560.

Revert "TRY TO FIX Travis.CI failure"

This reverts commit c67ac2e.

Revert "TRY TO FIX Travis.CI failure"

This reverts commit e5b477b.
Fish-Git added a commit that referenced this issue May 18, 2020
@Fish-Git
Fix for IPL command without a LOADPARM (#296)
a57edd6 
Closes #296.

[skip travis]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG The issue describes likely incorrect product functionality that likely needs corrected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fish-Git @arfineman