Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(password): ensure consistency in prompt appearence #1411

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

matteosacchetto
Copy link
Contributor

This PR fixes a small inconsistency in the presentation of the password prompt.

In the previous implementation, the prompt was missing a space between the message and the value, when the value was empty.
This fixes that and also makes sure that if you use do not pass a mask there is not an additional space between the message and the helpTip

This ensures that the password prompt is consistent with the input prompt (which already implements a similar fix), and ensures that it is consistent with how the password prompt appeared before the "style customization" update (ex. v1.1.15)

ensure that the password prompt handles spaces similarly to the input prompt
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@209b4ce). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1411   +/-   ##
=======================================
  Coverage        ?   96.89%           
=======================================
  Files           ?       54           
  Lines           ?     4990           
  Branches        ?      826           
=======================================
  Hits            ?     4835           
  Misses          ?      147           
  Partials        ?        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@SBoudrias SBoudrias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SBoudrias SBoudrias merged commit c3d311a into SBoudrias:main Jun 6, 2024
8 checks passed
@matteosacchetto matteosacchetto deleted the fix-password-prompt branch June 7, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants