Fix cursor when moved by 0

SBoudrias · Jan 7, 2016 · 33403fc · 33403fc · sindresorhus · Jan 10, 2016
1 parent eaefbf1
commit 33403fc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/lib/utils/readline.js b/lib/utils/readline.js
@@ -8,7 +8,9 @@ var ansiEscapes = require('ansi-escapes');
  */
 
 exports.left = function(rl, x) {
-  rl.output.write(ansiEscapes.cursorBackward(x));
+  if (x > 0) {
+    rl.output.write(ansiEscapes.cursorBackward(x));
+  }
 };
 
 /**
@@ -18,7 +20,9 @@ exports.left = function(rl, x) {
  */
 
 exports.right = function(rl, x) {
-  rl.output.write(ansiEscapes.cursorForward(x));
+  if (x > 0) {
+    rl.output.write(ansiEscapes.cursorForward(x));
+  }
 };
 
 /**
@@ -28,7 +32,9 @@ exports.right = function(rl, x) {
  */
 
 exports.up = function (rl, x) {
-  rl.output.write(ansiEscapes.cursorUp(x));
+  if (x > 0) {
+    rl.output.write(ansiEscapes.cursorUp(x));
+  }
 };
 
 /**
@@ -38,7 +44,9 @@ exports.up = function (rl, x) {
  */
 
 exports.down = function (rl, x) {
-  rl.output.write(ansiEscapes.cursorDown(x));
+  if (x > 0) {
+    rl.output.write(ansiEscapes.cursorDown(x));
+  }
 };
 
 /**

diff --git a/lib/utils/screen-manager.js b/lib/utils/screen-manager.js
@@ -54,6 +54,8 @@ ScreenManager.prototype.render = function (content, bottomContent) {
    * Re-adjust the cursor at the correct position.
    */
 
+  // We need to consider parts of the prompt under the cursor as part of the bottom
+  // content in order to correctly cleanup and re-render.
   var promptLineUpDiff = Math.floor(rawPromptLine.length / cliWidth()) - cursorPos.rows;
   var bottomContentHeight = promptLineUpDiff + (bottomContent ? bottomContent.split('\n').length : 0);
   if (bottomContentHeight > 0) {