Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update popup style and labels spacing #2440

Merged
merged 10 commits into from
Oct 10, 2024

Conversation

emrecevik06
Copy link
Contributor

@emrecevik06 emrecevik06 commented Oct 7, 2024

Update fundamental style of popups and add more space between labels and icons

  • Updated background color
  • Updated border color and radius
  • More spacing at labels and icons

Before:
image
image

After:
image
image

@emrecevik06 emrecevik06 requested review from a team as code owners October 7, 2024 09:59
Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: ceeb091

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sap-ux/control-property-editor Patch
@sap-ux/ui-components Patch
@sap-ux/ui-prompting Patch
@sap-ux-private/ui-prompting-examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@815are
Copy link
Contributor

815are commented Oct 8, 2024

@gpeuc @emrecevik06

just to be sure do we need border also for following callouts?
generic
image
generic callout used for translation input as example
image

current change only applies border color without border width and not sure if is it intended?

@gpeuc
Copy link
Contributor

gpeuc commented Oct 8, 2024

@815are Yep. All things that pop out should have border.

border: 1px solid var(--vscode-editorWidget-border);
border-radius: 2px;

(radius 4 is for big popups, large dialogs where we enter stuff, etc.)

815are
815are previously approved these changes Oct 9, 2024
Copy link
Contributor

@815are 815are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked:

  1. change in ui-components is clear and fits expectation - all generic callout has border
  2. tested ui-component update with storybook

Copy link
Contributor

@vadson71 vadson71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and straightforward.
Didn't test locally

Copy link

sonarcloud bot commented Oct 9, 2024

@vinayhospete vinayhospete merged commit e65bb7f into main Oct 10, 2024
13 checks passed
@vinayhospete vinayhospete deleted the fix/updatePopupStyleAndLabelsSpacing branch October 10, 2024 05:12
emrecevik06 added a commit that referenced this pull request Oct 11, 2024
* fix: more spacing at labels and icons

* fix: Update fundamental styling of popups

* changeset

* fix: adapt test

* fix: translation input story correction

translation input story correction

* fix: add border for all callouts

* update changesets

---------

Co-authored-by: Jimmy Joseph <[email protected]>
Co-authored-by: Andis Redmans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants