-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update popup style and labels spacing #2440
Conversation
🦋 Changeset detectedLatest commit: ceeb091 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@815are Yep. All things that pop out should have border.
(radius 4 is for big popups, large dialogs where we enter stuff, etc.) |
translation input story correction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked:
- change in
ui-components
is clear and fits expectation - all generic callout has border - tested
ui-component
update with storybook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and straightforward.
Didn't test locally
Quality Gate passedIssues Measures |
* fix: more spacing at labels and icons * fix: Update fundamental styling of popups * changeset * fix: adapt test * fix: translation input story correction translation input story correction * fix: add border for all callouts * update changesets --------- Co-authored-by: Jimmy Joseph <[email protected]> Co-authored-by: Andis Redmans <[email protected]>
Update fundamental style of popups and add more space between labels and icons
Before:
After: