Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating null values #2078

Merged
merged 9 commits into from
Jun 27, 2024
Merged

fix: updating null values #2078

merged 9 commits into from
Jun 27, 2024

Conversation

Jimmy-Joseph19
Copy link
Contributor

When updating the values of property values to null. Causes exception and removed the unwanted textNode creation for null cases

@Jimmy-Joseph19 Jimmy-Joseph19 requested a review from a team as a code owner June 25, 2024 21:15
Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: b53cf54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/fiori-annotation-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes looks good, but please fix the sonar issue.

packages/fiori-annotation-api/src/avt/to-internal.ts Outdated Show resolved Hide resolved
packages/fiori-annotation-api/src/change-converter.ts Outdated Show resolved Hide resolved
packages/fiori-annotation-api/src/change-converter.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 27, 2024

Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jimmy-Joseph19!

  • Code looks good
  • Good test coverage
  • Review comments addressed

@Jimmy-Joseph19 Jimmy-Joseph19 merged commit 3afada7 into main Jun 27, 2024
13 checks passed
@Jimmy-Joseph19 Jimmy-Joseph19 deleted the fix/handleNullValues branch June 27, 2024 10:19
devinea added a commit that referenced this pull request Jul 1, 2024
* origin/main:
  chore: apply latest changesets
  Enhancing the `generatePreviewFiles` to support all configurations and CAP (#2093)
  chore: apply latest changesets
  Feature: (1) list virtual preview files and (2) eject virtual files on request (#2062)
  chore: apply latest changesets
  fix: updating null values (#2078)
  chore: apply latest changesets
  feat: Add Adaptation Project's Change Data Source generator prompting (#1925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants