-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updating null values #2078
Conversation
🦋 Changeset detectedLatest commit: b53cf54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes looks good, but please fix the sonar issue.
return empty if undefined Co-authored-by: Davis Voicescuks <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jimmy-Joseph19!
- Code looks good
- Good test coverage
- Review comments addressed
* origin/main: chore: apply latest changesets Enhancing the `generatePreviewFiles` to support all configurations and CAP (#2093) chore: apply latest changesets Feature: (1) list virtual preview files and (2) eject virtual files on request (#2062) chore: apply latest changesets fix: updating null values (#2078) chore: apply latest changesets feat: Add Adaptation Project's Change Data Source generator prompting (#1925)
When updating the values of property values to null. Causes exception and removed the unwanted textNode creation for null cases