-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add local module cache to project-access #2066
Conversation
🦋 Changeset detectedLatest commit: 499a9c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature. Clearly implemented and tested.
Maybe it could be a separate module by itself, but fine for now.
changeset ✅
While implementing this in project-access I was thinking the same. Should be easily possible to extract into an own module if required. For now I think it could remain with project access. |
Please retry analysis of this Pull-Request directly on SonarCloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- code is easy to understand and structured
- tests and great coverage provided
- Manual test ok (consumption via tools-suite with VSIX)
- check, change, reload of modules
Quality Gate passedIssues Measures |
Add feature to locally cache node modules. First consumer of this is specification to cache local versions of
@sap/ux-specification
.The cache for node modules is located at
~/.fioritools/module-cache
. A folder structure including scope, name, and version will be created for each cached module. For instance, module@scope/[email protected]
will installed in~/.fioritools/module-cache/@scope/module/1.2.3
which will result in following folder structure:New public exported functions:
and