-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deploy-config): adds new abap deploy config writer #2056
Conversation
🦋 Changeset detectedLatest commit: 4bd8cfc The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@tobiasqueck My next task is to implement the corresponding inquirer for this module. Ideally I would like to publish this writer, the inquirer, and at that point enhance the However, if there is urgency on this being added to the |
…//github.com/SAP/open-ux-tools into feat/deploy-config/abap-deploy-config-writer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
New module setup ✅
project access ✅
ui5-config ✅
yaml ✅
changeset ✅
packages/abap-deploy-config-writer/test/sample/test-ts-app/tsconfig.json
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cianmSAP Thanks for the updates.
All good from my perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DIdnt test locally.
Addresesses the CLI version changes i.e. no longer require UI5 dependencies to be added.
Test coverage is good.
WIll be consumed into tools-suite where the unit test and integration test coverage is high and should
catch any bugs!
#2006
Adds new abap deploy config writer