Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy-config): adds new abap deploy config writer #2056

Merged
merged 13 commits into from
Jun 25, 2024

Conversation

cianmSAP
Copy link
Contributor

@cianmSAP cianmSAP commented Jun 20, 2024

#2006

Adds new abap deploy config writer

Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: 4bd8cfc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/project-access Patch
@sap-ux/ui5-config Patch
@sap-ux/yaml Patch
@sap-ux/adp-tooling Patch
@sap-ux/app-config-writer Patch
@sap-ux/cap-config-writer Patch
@sap-ux/cards-editor-config-writer Patch
@sap-ux/cards-editor-middleware Patch
@sap-ux/create Patch
@sap-ux/environment-check Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/mockserver-config-writer Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/odata-service-writer Patch
@sap-ux/preview-middleware Patch
@sap-ux/telemetry Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-application-writer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/ui5-proxy-middleware Patch
@sap-ux/deploy-tooling Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cianmSAP cianmSAP marked this pull request as ready for review June 21, 2024 10:08
@cianmSAP cianmSAP requested review from a team as code owners June 21, 2024 10:08
@tobiasqueck
Copy link
Contributor

@cianmSAP could you please also enhance the create module and use the write for the command add deploy-config. Then we have everything in the PR that allows e2e tests.

@testojs please verify that this also works for ADP (I don't see a reason why not but please check)

@cianmSAP
Copy link
Contributor Author

cianmSAP commented Jun 21, 2024

@cianmSAP could you please also enhance the create module and use the write for the command add deploy-config. Then we have everything in the PR that allows e2e tests.

@tobiasqueck My next task is to implement the corresponding inquirer for this module. Ideally I would like to publish this writer, the inquirer, and at that point enhance the create module.

However, if there is urgency on this being added to the create module, I'd like to do it in a follow up PR as the one is already reasonably large touching multiple modules.

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
New module setup ✅
project access ✅
ui5-config ✅
yaml ✅
changeset ✅

packages/abap-deploy-config-writer/src/config.ts Outdated Show resolved Hide resolved
packages/abap-deploy-config-writer/src/index.ts Outdated Show resolved Hide resolved
packages/abap-deploy-config-writer/src/index.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 24, 2024

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cianmSAP Thanks for the updates.
All good from my perspective.

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DIdnt test locally.
Addresesses the CLI version changes i.e. no longer require UI5 dependencies to be added.
Test coverage is good.
WIll be consumed into tools-suite where the unit test and integration test coverage is high and should catch any bugs!

@cianmSAP cianmSAP merged commit 399d2ad into main Jun 25, 2024
13 checks passed
@cianmSAP cianmSAP deleted the feat/deploy-config/abap-deploy-config-writer branch June 25, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants