Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cap-config-writer): update cds plugin ui5 #2054

Merged
merged 12 commits into from
Jun 24, 2024

Conversation

korotkovao
Copy link
Contributor

TBI - Update cds-plugin-ui5 version #2053

There is a fix introduced in the latest cds-plugin-ui5: "^0.9" for the CAP Kyma build compatibility.

Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: 0d8ddc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/cap-config-writer Minor
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this need to be updated?

const minCdsPluginUi5Version = '0.6.13';

@korotkovao
Copy link
Contributor Author

Doesn't this need to be updated?

const minCdsPluginUi5Version = '0.6.13';

Yes, thank you!

Copy link

sonarcloud bot commented Jun 21, 2024

@korotkovao korotkovao requested a review from devinea June 21, 2024 15:12
Copy link
Contributor

@Klaus-Keller Klaus-Keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump for min cds plugin version looks good, approved from my side.

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Thanks for making changes.

@korotkovao
Copy link
Contributor Author

Thank you All

@korotkovao korotkovao merged commit 04ed040 into main Jun 24, 2024
13 checks passed
@korotkovao korotkovao deleted the feat/2053/update-cds-plugin-ui5-version branch June 24, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants