-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cap-config-writer): update cds plugin ui5 #2054
Conversation
🦋 Changeset detectedLatest commit: 0d8ddc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/cap-config-writer/test/fixture/cap-valid-cds-plugin-ui/package.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this need to be updated?
const minCdsPluginUi5Version = '0.6.13'; |
Yes, thank you! |
Co-authored-by: Austin Devine <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version bump for min cds plugin version looks good, approved from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
Thanks for making changes.
Thank you All |
TBI - Update cds-plugin-ui5 version #2053
There is a fix introduced in the latest cds-plugin-ui5: "^0.9" for the CAP Kyma build compatibility.