Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add toolsId in ui5.yaml for Adaptation Project writers and remove safeMode #2042

Open
wants to merge 70 commits into
base: main
Choose a base branch
from

Conversation

nikmace
Copy link
Contributor

@nikmace nikmace commented Jun 17, 2024

Feat for #2039.

  • Adds support section with toolsId.
  • Removes safeMode.

IvoSG and others added 30 commits March 24, 2024 13:20
…cture, adapt commands, remove unused dependencie
@nikmace nikmace added feature New feature or request create @sap-ux/create adp-tooling labels Jun 17, 2024
@nikmace nikmace self-assigned this Jun 17, 2024
@nikmace nikmace requested review from a team as code owners June 17, 2024 14:01
Copy link

changeset-bot bot commented Jun 17, 2024

🦋 Changeset detected

Latest commit: 4340593

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux/adp-tooling Patch
@sap-ux/create Patch
@sap-ux/preview-middleware Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikmace nikmace changed the base branch from main to feat/1611/writersForAdpProjects June 17, 2024 14:02
Base automatically changed from feat/1611/writersForAdpProjects to main June 17, 2024 14:07
* @returns {Object} An object containing the `name` and `version` of the package.
*/
export function getPackageJSONInfo(): { name: string; version: string } {
const defaultPackage = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define return object as type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in: 2c78497

@nikmace nikmace requested a review from GDamyanov July 1, 2024 05:27
Copy link

sonarcloud bot commented Jul 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adp-tooling create @sap-ux/create feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants