feat: Launch config package #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 547c4af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Klaus-Keller
requested changes
Jul 10, 2024
There was a problem hiding this comment.
Hi @broksy, could you please check the sonar code smells: https://sonarcloud.io/project/issues?id=SAP_open-ux-tools&pullRequest=2040&resolved=false&sinceLeakPeriod=true
packages/launch-config/test/test-data/test-workspace/fe-project/cap/srv/incidentservice.js
Outdated
Show resolved
Hide resolved
Klaus-Keller
requested changes
Jul 12, 2024
Klaus-Keller
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Thanks @broksy!
- new module is well structured
- changeset exists
- test coverage is good
- did a manual test, no issues found
Approved from my side.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing package for managing VSCode launch configurations in
.vscode/launch.json.