Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore - update tsconfig target ES version to ES2022 aligning with NodeJS 18+ #2023

Merged
merged 18 commits into from
Jul 5, 2024

Conversation

devinea
Copy link
Member

@devinea devinea commented Jun 7, 2024

Update ES target to ES2022.

  • output Javascript is smaller and easier to debug and read.
  • No longer need to support older runtime envs.

@devinea devinea requested a review from a team as a code owner June 7, 2024 14:29
Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: 57320ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 61 packages
Name Type
@sap-ux/odata-cli Minor
@sap-ux/generator-simple-fe Minor
@sap-ux/adp-tooling Minor
@sap-ux/app-config-writer Minor
@sap-ux/axios-extension Minor
@sap-ux/backend-proxy-middleware Minor
@sap-ux/btp-utils Minor
@sap-ux/cap-config-writer Minor
@sap-ux/cards-editor-config-writer Minor
@sap-ux/cards-editor-middleware Minor
@sap-ux/cds-annotation-parser Minor
@sap-ux/cds-odata-annotation-converter Minor
@sap-ux-private/control-property-editor-common Minor
@sap-ux/create Minor
@sap-ux/deploy-tooling Minor
@sap-ux/environment-check Minor
@sap-ux/eslint-plugin-fiori-tools Minor
@sap-ux/fe-fpm-writer Minor
@sap-ux/feature-toggle Minor
@sap-ux/fiori-elements-writer Minor
@sap-ux/fiori-freestyle-writer Minor
@sap-ux/fiori-generator-shared Minor
@sap-ux/i18n Minor
@sap-ux/inquirer-common Minor
@sap-ux/jest-file-matchers Minor
@sap-ux/jest-runner-puppeteer Minor
@sap-ux/logger Minor
@sap-ux/mockserver-config-writer Minor
@sap-ux/odata-annotation-core Minor
@sap-ux/odata-annotation-core-types Minor
@sap-ux/odata-entity-model Minor
@sap-ux/odata-service-inquirer Minor
@sap-ux/odata-service-writer Minor
@sap-ux/odata-vocabularies Minor
@sap-ux-private/playwright Minor
@sap-ux/preview-middleware Minor
@sap-ux-private/preview-middleware-client Minor
@sap-ux/project-access Minor
@sap-ux/project-input-validator Minor
@sap-ux/reload-middleware Minor
@sap-ux/serve-static-middleware Minor
@sap-ux/store Minor
@sap-ux/system-access Minor
@sap-ux/telemetry Minor
@sap-ux/ui-components Minor
@sap-ux/ui5-application-inquirer Minor
@sap-ux/ui5-application-writer Minor
@sap-ux/ui5-config Minor
@sap-ux/ui5-info Minor
@sap-ux/ui5-library-inquirer Minor
@sap-ux/ui5-library-reference-inquirer Minor
@sap-ux/ui5-library-reference-writer Minor
@sap-ux/ui5-library-writer Minor
@sap-ux/ui5-proxy-middleware Minor
@sap-ux/ui5-test-writer Minor
@sap-ux/xml-odata-annotation-converter Minor
@sap-ux/yaml Minor
@sap-ux/types Minor
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/annotation-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

IainSAP
IainSAP previously approved these changes Jun 7, 2024
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

devinea and others added 4 commits June 7, 2024 19:18
* origin/es2021_update:
  remove @sap-ux/control-property-editor as it has its own es target config
  chore: apply latest changesets
  tbi(@sap-ux/cap-config-writer): Add additional cap configuration writing functionalities (#1902)
* origin/main:
  chore: apply latest changesets
  fix: Add new model writer has misspelled property that breaks the validation of the change (#2016)
@devinea devinea requested review from a team as code owners June 10, 2024 17:21
* origin/main:
  chore: apply latest changesets
  feat(fiori-elements-writer): remove `sap.fe.templates` dependency v4 fpm (#1948)
  chore: apply latest changesets
  fix: UIContextualMenu. Wrong visualisation of menu item without text when menu contains at least one menu item with icon (#2008)
  chore: apply latest changesets
  fix(axios-entension): Prevent `createServiceForUrl` param over-writing (#2027)
Copy link
Contributor

@Klaus-Keller Klaus-Keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devinea, switch to ES2022 looks good, approved from my side.

@devinea devinea requested a review from tobiasqueck June 24, 2024 19:05
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @devinea

  • es version update only, changes as expected

* origin/main:
  chore: apply latest changesets
Copy link

sonarcloud bot commented Jul 5, 2024

Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Control Property Editor changes looks good and tested it locally with node 18.

@devinea devinea merged commit c235907 into main Jul 5, 2024
13 checks passed
@devinea devinea deleted the es2021_update branch July 5, 2024 14:53
devinea added a commit that referenced this pull request Jul 5, 2024
* origin/main:
  Chore - update tsconfig target ES version to ES2022 aligning with NodeJS 18+ (#2023)
  chore: apply latest changesets
  fix(env-check): add sap-client to axios request params (#2122)
  chore upgrade nx (#2104)
  chore: apply latest changesets
  Include Templates in 'files' Array of fiori-generator-shared Package.json bug#2111 (#2113)
  chore: apply latest changesets
  feat(annotation-generator): add annotation generation package (#2110)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants