Add cds specific vocabularies for analytics support #1522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC for supporting non-OData annotations in CDS LSP.
Still to do (by cds/analytics colleagues):
$AppliesTo
, usage ofEdm.PropertyPath
andEdm.NavigationPropertyPath
)@Validation.AllowedValues
- alternative is "real" ODataEnumType
(see@Aggreagtion.default
https://github.com/SAP/open-ux-tools/pull/1522/files#r1410695634)Here is some background explanation and also a demo on how this looks in action:
https://github.com/SAP/open-ux-tools/assets/107176531/121edf7c-73b1-4abf-8377-36f5abc625df
After converting allowed values to odata
enumTypes
it looks as follows:for
@Aggregartion.default
(both value lists are added up):Regarding conflicting vocabulary alias
Aggregation
(there is an Odata vocabulary and now a cds specific one with the same name): current workaround is that the cds terms are logically added to the OData vocabulary. This way we could restrict the code changes to the vocabulary package only. Drawback (I hope acceptable) is that hover/cc item text for@Aggregation.default
show wrong namespace: