Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment in launch.json #90

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

fakirdi
Copy link
Contributor

@fakirdi fakirdi commented Dec 6, 2023

Comments are generating the syntax error:

SyntaxError: Unexpected token / in JSON at position 4 · Issue #89 · SAP-samples/fiori-elements-v4-cap-advanced · GitHub

Request from Christoph Laux und Christoph Gollmick to remove comments.

Comments are generating the syntax error:

SyntaxError: Unexpected token / in JSON at position 4 · Issue SAP-samples#89 · SAP-samples/fiori-elements-v4-cap-advanced · GitHub
Copy link

cla-assistant bot commented Dec 6, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Dec 6, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hitesh-parmar hitesh-parmar self-requested a review December 6, 2023 14:59
Reverting comments and adding a new line:

comments will be supported with the next release of SAP Fiori tools i.e. 1.12.0
@hitesh-parmar hitesh-parmar changed the title Update launch.json removing the comments Update comment in launch.json Dec 6, 2023
@hitesh-parmar
Copy link
Collaborator

Comments will be supported with next release of SAP Fiori tools i.e. 1.12.0

@hitesh-parmar hitesh-parmar merged commit 1c51a71 into SAP-samples:main Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants