Update versions and adapt instructions for trial #11
Conversation
Updated CDS Services versions to 1.2.0 and performed necessary code changes. Updated instructions to explain how to use CloudPlatform Trial accounts. Therefore also removed reference to XXX or other instructor provided details.
|
@agoerler Can you also have a look please :) |
| mvn -B archetype:generate -DarchetypeArtifactId=cds-services-archetype -DarchetypeGroupId=com.sap.cds \ | ||
| -DarchetypeVersion=1.0.1 -DcdsVersion=3.17.4 \ | ||
| -DarchetypeVersion=1.2.0 -DcdsVersion=3.21.2 \ | ||
| -DgroupId=com.sap.teched.cap -DartifactId=products-service -Dpackage=com.sap.teched.cap.productsservice |
There was a problem hiding this comment.
We should replace this with a shorter call to cds init. I guess, you prefer to still have the fixed archetype and cds versions in it, right?
There was a problem hiding this comment.
Yes, but the other problem is that we want to use version 1.2.0, but the CDS-DK version available on AppStudio only provides 1.1.0. Also we don't want to initialize sample data, which was surprisingly added by cds init by default.
There was a problem hiding this comment.
So this means if we add the 3 parameters archetypeVersion, cdsVersion, and samples (or so) to cds init, it would work?
Would be something like
cds init products-service --add java --java:archetypeVersion=1.2.0 --java:cdsVersion=3.21.2
samples should default to false anyways, to align it with Node.js
There was a problem hiding this comment.
Yes, that would be great :)
There was a problem hiding this comment.
Ok, I will align this with Joerg once I know his github user.
For the time being, we can leave the archetype call here.
| @@ -85,7 +85,9 @@ You will now add a method to the `OrdersService` Java class to decrease the stoc | |||
| @Before(event = CdsService.EVENT_CREATE, entity = "OrdersService.Orders") | |||
| public void validateBookAndDecreaseStockViaOrders(List<Orders> orders) { | |||
| for(Orders order : orders) { | |||
| validateBookAndDecreaseStock(order.getItems()); | |||
| if(order.getItems() != null) { | |||
There was a problem hiding this comment.
CDS4J does not automatically initialize collection-based types with empty lists anymore upon calling the getter, but returns null now.
| @@ -247,7 +249,9 @@ Finally, add a method to the `OrdersService` Java class to calculate the `total` | |||
| public void calculateTotal(List<Orders> orders) { | |||
| for (Orders order : orders) { | |||
| // calculate net amount for expanded items | |||
| calculateNetAmount(order.getItems()); | |||
| if(order.getItems() != null) { | |||
Updated CDS Services versions to 1.2.0 and performed necessary code changes.
Updated instructions to explain how to use CloudPlatform Trial accounts.
Therefore also removed reference to XXX or other instructor provided details.