Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the Method of Morris, result metric sigma is not computed correctly #65

Closed
willu47 opened this issue Jul 24, 2015 · 1 comment
Closed

In the Method of Morris, result metric sigma is not computed correctly #65

willu47 opened this issue Jul 24, 2015 · 1 comment
Labels
bug

Comments

@willu47
Copy link
Member

willu47 commented Jul 24, 2015

The result metric sigma should be an unbiased estimator of the sample variation. The current way of computing the standard deviation (np.std(ee)) is incorrect, and should be changed to np.std(ee, ddof=1)
@willu47 willu47 added the bug label Jul 24, 2015
@willu47 willu47 mentioned this issue Jul 24, 2015
Merged
jdherman added a commit that referenced this issue Jul 24, 2015
@jdherman
Merge pull request #66 from willu47/bug_sigma
b705b4d 
Solves #65
@jdherman
Copy link
Member

Woops, my fault. Thanks for noticing this.

Closed by #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdherman @willu47