Allow alternate sampling distributions for all methods #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed leftover examples for Python 2 Added advanced examples for `readthedocs` and examples for generating alternate non-uniform distributions
|
Added documentation for sampling non-uniform distributions Resolves #308 Partially addresses #274 pinging @DmitriyValetov regarding #338 |
|
In #339, prototype unified interface is provided, with the intention that sample scaling could be conducted at a single place in the codebase. Some methods, however, cannot be scaled post hoc (e.g. DGSM) so this needs to be kept in mind for the problem-spec approach, and possibly other aspects relating to #234. This is one reason why use of the These specific cases will have to be handled... |
ConnectedSystems
changed the title
ConnectedSystems
changed the base branch from
master
to
experimental-methods
|
Updated documentation will also resolve #332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize scaling process for all sampling methods.
Note: The
unscale_sampleswill need to be adjusted or generalized but it does not appear to be used internally.@willu47 Would you be available to push out a new release once I add documentation?
Replaces #192 (with apologies to @willu47 and @filssavi)
Resolves #329 #343
pinging @MatthiVH