Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morris sample problem in boundary-distribution definition: bounds are not legal. #329 #343

Open
MatthiVH opened this issue Sep 9, 2020 · 3 comments · Fixed by #346
Open
Assignees

Comments

@MatthiVH
Copy link

MatthiVH commented Sep 9, 2020

Same issue as #329 but now for the Morris sampler.

The saltelli sampler can handle other distributions in the problem definition, however the Morris sampler can not.

I assume the Morris sampler doesn't recognise the 'dists'-statement in the problem-definition and assumes all uniform.
Can this be fixed?

Regards,
Matthias

@ConnectedSystems
Copy link
Member

I'll have a look at this sometime over the next few days - finding time is an issue at the moment so I can't promise anything concrete.

@MatthiVH
Copy link
Author

No problem, that's perfect.

@ConnectedSystems
Copy link
Member

Hi @MatthiVH

I'm not sure when the next release will be made, but in the meantime you can try out the "bleeding edge" development version:

Please do note that this version has a number of changes and has not been extensively tested.

pip install git+https://github.com/SALib/SALib.git@experimental-methods

Specific to your case, sampling non-uniform distributions may not work with groups of parameters (for Morris in particular).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants