implementation of md6 in pure rust #636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
requested changes
Dec 25, 2024
There was a problem hiding this comment.
We can not merge this implementation in such state.
Please, do not disable the Clippy lints, follow the trait API defined in the digest crate, keep the crate no_std-capable (i.e. your code should not have any Vecs), add a CI workflow config for this crate (you can use the md5 file for reference), add the crate to the workspace by modifying the root Cargo.toml file, and remove the md6/.gitignore file.
Our trait APIs are a bit complex (and not documented that well), so I recommend taking a look at other crates in this repository first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of md6 in pure rust.