Add newline to PublicKey::write_openssh_file output
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb6eff2
to
4fc9264
Compare
Also adds an integration test to ensure that the file output matches what `ssh-keygen` generates byte-for-byte. The `ToString` impl still omits the newline. To avoid making breaking changes, it always uses `\n` as the newline, however perhaps in a future breaking release it could be changed to accept `LineEnding` so as to match `PrivateKey::write_openssh_file`.
4fc9264
to
ab2531f
Compare
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds an integration test to ensure that the file output matches what
ssh-keygengenerates byte-for-byte.The
ToStringimpl still omits the newline.To avoid making breaking changes, it always uses
\nas the newline, however perhaps in a future breaking release it could be changed to acceptLineEndingso as to matchPrivateKey::write_openssh_file.Fixes #187.