Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #775 (comment)
Fixed
asio-sys/src/bindings/errors.rs
std::Error::description()
has been deprecated.It should be replaced with
std::fmt::Display
I found some code duplication in the
std::fmt::Display
andstd::Error
trait, so I have combined the code instd::fmt::Display
.This will be a breaking change, is that OK?
The
std::Error
implementation ofLoadDriverError
andAsioError
is empty, but I think this is necessary for error handling, so I left it.Fixed
src/host/asio/stream.rs
I wondered what to do with the
asio_stream
field, but decided to ignore the warning as it might be there to extend the lifetime.I am not 100% sure that this is the right way to do it.