Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warnings in asio_sys #779

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Fixed warnings in asio_sys #779

merged 2 commits into from
Jul 20, 2023

Conversation

Dicklessgreat
Copy link
Contributor

From #775 (comment)

Fixed asio-sys/src/bindings/errors.rs
std::Error::description() has been deprecated.
It should be replaced with std::fmt::Display
I found some code duplication in the std::fmt::Display and std::Error trait, so I have combined the code in std::fmt::Display.
This will be a breaking change, is that OK?
The std::Error implementation of LoadDriverError and AsioError is empty, but I think this is necessary for error handling, so I left it.

Fixed src/host/asio/stream.rs
I wondered what to do with the asio_stream field, but decided to ignore the warning as it might be there to extend the lifetime.I am not 100% sure that this is the right way to do it.

Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@est31 est31 merged commit d0ff4fe into RustAudio:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants