forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the name of wait_list
to wait_queue_head
in CondVar
#1048
Labels
Comments
y86-dev
added
• lib
Related to the `rust/` library.
good first issue
Good for newcomers
labels
Dec 13, 2023
AdilDyer
added a commit
to AdilDyer/linux
that referenced
this issue
Dec 13, 2023
Fixes:Rust-for-Linux#1048 / Update condvar.rs
@AdilDyer are you still working on that one? Otherwise I‘d like to take the opportunity to learn how to submit a patch to the mailing list (never done that before). @y86-dev In any case I'd be interested what "test your changes" means in this context? Anything besides the things mentioned in the contributing guidelines. Update: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CondVar
currently has a field calledwait_list
, but its type isOpaque<bindings::wait_queue_head>
. Change the name towait_queue_head
to avoid confusion, since fields that are namedwait_list
normally have the typestruct list_head
.This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes, to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and so on. Please see https://docs.kernel.org/process/submitting-patches.html and https://rust-for-linux.com/contributing for details.
Please take this issue only if you are new to the kernel development process and you would like to use it as a test to submit your first patch to the kernel.
The text was updated successfully, but these errors were encountered: