Skip to content

Commit

Permalink
perf record: Reduce memory for recording PERF_RECORD_LOST_SAMPLES event
Browse files Browse the repository at this point in the history
Reduce from PERF_SAMPLE_MAX_SIZE to "sizeof(*lost) +
session->machines.host.id_hdr_size".

Suggested-by: Namhyung Kim <[email protected]>
Signed-off-by: Ian Rogers <[email protected]>
Cc: Adrian Hunter <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
  • Loading branch information
captain5050 authored and acmel committed Jan 3, 2024
1 parent 9c51f87 commit 7d1405c
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions tools/perf/builtin-record.c
Original file line number Diff line number Diff line change
Expand Up @@ -1954,7 +1954,8 @@ static void record__read_lost_samples(struct record *rec)

if (count.lost) {
if (!lost) {
lost = zalloc(PERF_SAMPLE_MAX_SIZE);
lost = zalloc(sizeof(*lost) +
session->machines.host.id_hdr_size);
if (!lost) {
pr_debug("Memory allocation failed\n");
return;
Expand All @@ -1970,7 +1971,8 @@ static void record__read_lost_samples(struct record *rec)
lost_count = perf_bpf_filter__lost_count(evsel);
if (lost_count) {
if (!lost) {
lost = zalloc(PERF_SAMPLE_MAX_SIZE);
lost = zalloc(sizeof(*lost) +
session->machines.host.id_hdr_size);
if (!lost) {
pr_debug("Memory allocation failed\n");
return;
Expand Down

0 comments on commit 7d1405c

Please sign in to comment.