Update encoding loop to recommended algorithm; add drain loop. #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#191 mentions that the code in H264VideoStreamEncoder.cs isn't a "correct" encoding loop.
I implemented the recommended loop from https://ffmpeg.org/doxygen/4.1/group__lavc__encdec.html
It's a bit more verbose than it needs to be, but explains the algorithm as it goes.
I think the original H264VideoStreamEncoder.cs had 2 problems:
Thanks for your great work in this project!