Improves Precision and Simplifies Allocation Logic #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converts all numeric parameters to BigDecimal when any is a BigDecimal, Float, or Rational, enhancing calculation precision. - Removes obsolete round-robin penny distribution for a more straightforward allocation approach.
|
running tests. would you mind fixing the CHF test too please? |
Fixed the CHF test and pushed the changes. Anything else needed? |
semmons99
approved these changes
Mar 6, 2024
|
all good. thanks. will release to rubygems shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I had noticed a small error in the round-robin distribution logic: #1074
Upon further reflection, I think the reason for introducing the round-robin distribution was lack of precision. By increasing the precision to BigDecimal, the case described in #1033 seems to be solved and the round-robin distribution becomes obsolete.
What do you think of this @semmons99 ?
This #1073 would of course no longer make sense.
Note: The only failing test has nothing to do with my changes, but apparently with the formatting for CHF