Fixed code analyzed issues.

RoyZeng · Apr 6, 2017 · 16f92ef · 16f92ef
1 parent 6df017d
commit 16f92ef
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/...c/main/java/com/dangdang/ddframe/job/lite/console/domain/EventTraceDataSourceFactory.java b/...c/main/java/com/dangdang/ddframe/job/lite/console/domain/EventTraceDataSourceFactory.java
@@ -1,18 +1,16 @@
 package com.dangdang.ddframe.job.lite.console.domain;
 
-import java.util.concurrent.ConcurrentHashMap;
-
-import com.dangdang.ddframe.job.lite.console.domain.EventTraceDataSourceConfiguration;
 import com.google.common.base.Charsets;
 import com.google.common.base.Optional;
 import com.google.common.base.Strings;
 import com.google.common.hash.HashCode;
 import com.google.common.hash.Hasher;
 import com.google.common.hash.Hashing;
-
 import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 
+import java.util.concurrent.ConcurrentHashMap;
+
 /**
  * 事件追踪数据源工厂.
  *

diff --git a/elastic-job-lite/elastic-job-lite-console/src/main/resources/console/index.html b/elastic-job-lite/elastic-job-lite-console/src/main/resources/console/index.html
@@ -113,7 +113,7 @@ <h4 class="control-sidebar-heading">更换主题皮肤</h4>
  <li>
  <a href="javascript:void(0);" data-skin="skin-black" class="clearfix full-opacity-hover">
  <div>
- <span class="top-span" id="span-black"></span>
+ <span class="top-span"></span>
  </div>
  <div>
  <span class="down-span-left"></span>
@@ -185,7 +185,7 @@ <h4 class="control-sidebar-heading">更换主题皮肤</h4>
  <li>
  <a href="javascript:void(0);" data-skin="skin-black-light" class="clearfix full-opacity-hover">
  <div>
- <span class="top-span" id="span-black"></span>
+ <span class="top-span"></span>
  </div>
  <div>
  <span class="down-span-left"></span>

diff --git a/...com/dangdang/ddframe/job/lite/lifecycle/internal/statistics/JobStatisticsAPIImplTest.java b/...com/dangdang/ddframe/job/lite/lifecycle/internal/statistics/JobStatisticsAPIImplTest.java
@@ -27,9 +27,7 @@
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
 
-import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.List;
 
 import static org.hamcrest.core.Is.is;
 import static org.junit.Assert.assertThat;
@@ -87,14 +85,12 @@ public void assertGetAllJobsBriefInfo() {
  when(regCenter.getChildrenKeys("/test_job_1/instances")).thenReturn(Arrays.asList("ip1@-@defaultInstance"));
  when(regCenter.getChildrenKeys("/test_job_2/instances")).thenReturn(Arrays.asList("ip1@-@defaultInstance", "ip2@-@defaultInstance"));
  int i = 0;
- List<String> shardingItems = new ArrayList<>();
  for (JobBriefInfo each : jobStatisticsAPI.getAllJobsBriefInfo()) {
  i++;
  assertThat(each.getJobName(), is("test_job_" + i));
  assertThat(each.getDescription(), is("desc" + i));
  assertThat(each.getCron(), is("0/1 * * * * ?"));
  assertThat(each.getJobType(), is("SIMPLE"));
- shardingItems.add(String.valueOf(i));
  assertThat(each.getInstanceCount(), is(i));
  assertThat(each.getShardingTotalCount(), is(3));
  }