Skip to content

Commit

Permalink
Handle header-only processes in spindump reports
Browse files Browse the repository at this point in the history
  • Loading branch information
inket committed Sep 18, 2022
1 parent ab2b355 commit ad2b1c5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion MacSymbolicator/Controllers/Symbolicator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ struct Symbolicator {
return false
}

guard !process.binaryImages.isEmpty else {
// Some processes in spindump reports might not have anything besides the header;
// Make sure to check that we have calls before dismissing it due to missing binary images section
if !process.calls.isEmpty && process.binaryImages.isEmpty {
logController.addLogMessage("""
Could not detect application binary images for reported process \(process.name ?? "<null>").\
Application might have crashed during launch.
Expand Down

0 comments on commit ad2b1c5

Please sign in to comment.