Validate the name of the topic when it's being unsubscribed #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, when the bridge received the operation code 'unsubscribe', it will not validate the topic name(e.g. validity of the topic or if it existed). This patch implements that when receiving the 'unsubscribe' op, the bridge will valide the name of the topic first. If the name itself is invalid, an error will return. If the topic name doesn't exist, a warning will return. Fix RobotWebTools#87
|
@minggangw , sure. Meanwhile, I'll uncomment the one test case in suite test-unsubscribe.js to see if it can pass. Then you can release a new version, is that OK? |
|
No problem. |
|
@minggangw , I just tested and #87 was fixed by this patch. The uncommented test case can pass as well. Please merge this PR. |
|
Thanks, will merge it soon. |
|
Thanks! I'll uncomment the test case metioned above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, when the bridge received the operation code 'unsubscribe',
it will not validate the topic name(e.g. validity of the topic or if it existed).
This patch implements that when receiving the 'unsubscribe' op, the bridge will
valide the name of the topic first. If the name itself is invalid, an error will
return. If the topic name doesn't exist, a warning will return.
Fix #87