Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] rosbridge v2 protocol testing: advertise/unadvertise op #38

Merged
merged 2 commits into from
Feb 12, 2018

Conversation

qiuzhong
Copy link
Collaborator

advertise/unadvertise operation test cases added.

@qiuzhong
Copy link
Collaborator Author

Please don't merge as some test cases will not pass as spec not completely implemented.

@qiuzhong qiuzhong force-pushed the protocol branch 2 times, most recently from 8953958 to f7ef9c7 Compare February 9, 2018 07:39
@qiuzhong qiuzhong changed the title [test] rosbridge v2 protocol testing [test] rosbridge v2 protocol testing: advertise/unadvertise op Feb 9, 2018
@qiuzhong qiuzhong force-pushed the protocol branch 2 times, most recently from aa6fb87 to 940ba8a Compare February 9, 2018 08:39
@qiuzhong
Copy link
Collaborator Author

qiuzhong commented Feb 9, 2018

I'm blocked by the fact that the CI on Windows failed while succeeded on Linux. I'm fixing it.

@minggangw
Copy link
Member

I suppose you have more than one WebSockets server instances, which will be listening the same port. This may lead to the TCP error, please try use different port or guarantee there is only one server instance at any time.

advertise/unadvertise operation test cases added (+11).
@qiuzhong
Copy link
Collaborator Author

Using different ports for multiple server instances doesn't help. I'm trying to avoid creating/destroying multiple bridge servers in my test cases to see if it can help.

advertise/unadvertise operation test cases added (+11).
@minggangw
Copy link
Member

It seems the windows ci doesn't complain :)

@qiuzhong
Copy link
Collaborator Author

qiuzhong commented Feb 12, 2018

Finally it passed on Windows CI!

@minggangw
Copy link
Member

So can I merge this PR now, if you will not change it any more?

@qiuzhong
Copy link
Collaborator Author

I think you can merge it now.

@minggangw
Copy link
Member

OK, merging...

@minggangw minggangw merged commit 1e8f92b into RobotWebTools:develop Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants